Re: Virtual generated columns

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>

To: jian he <jian.universality@gmail.com>

Cc: Dean Rasheed <dean.a.rasheed@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2024-11-05T16:19:01Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Expand virtual generated columns for ALTER COLUMN TYPE
- 5069fef1cfae 18.0 landed
Eliminate code duplication in replace_rte_variables callbacks
- 363a6e8c6fcf 18.0 landed
Expand virtual generated columns in the planner
- 1e4351af329f 18.0 landed
Virtual generated columns
- 83ea6c54025b 18.0 landed
Additional tests for stored generated columns
- 41084409f635 18.0 landed
Improve generated_stored test
- 44b61efb7928 18.0 landed
- 86749ea3b766 18.0 landed
Fix handling of CREATE DOMAIN with GENERATED constraint syntax
- 84a67725cd11 18.0 landed
Add pg_constraint rows for not-null constraints
- 14e87ffa5c54 18.0 cited
Put generated_stored test objects in a schema
- 894be11adfa6 18.0 landed
Rename regress test generated to generated_stored
- b9ed4969250d 18.0 landed
Small code simplification
- 7ff9afbbd1df 18.0 landed
Remove useless code
- e26d313bad92 18.0 landed
Remove useless initializations
- da2aeba8f533 18.0 landed
doc: Clarify that pg_attrdef also stores generation expressions
- da486d360103 18.0 landed
Clean out column-level pg_init_privs entries when dropping tables.
- 76618097a6c0 17.0 cited
Re-implement the ereport() macro using __VA_ARGS__.
- e3a87b4991cc 13.0 cited

On 16.09.24 11:22, jian he wrote:
> in v7.
> 
> doc/src/sgml/ref/alter_table.sgml
> <phrase>and <replaceable
> class="parameter">column_constraint</replaceable> is:</phrase>
> 
> section need representation of:
> GENERATED ALWAYS AS ( <replaceable>generation_expr</replaceable> ) [VIRTUAL]

I have addressed this in patch v8.

> in RelationBuildTupleDesc(Relation relation)
> we need to add "constr->has_generated_virtual" for the following code?
> 
>      if (constr->has_not_null ||
>          constr->has_generated_stored ||
>          ndef > 0 ||
>          attrmiss ||
>          relation->rd_rel->relchecks > 0)

fixed in v8

> also seems there will be table_rewrite for adding virtual generated
> columns, but we can avoid that.
> The attached patch is the change and the tests.
> 
> i've put the tests in src/test/regress/sql/fast_default.sql,
> since it already has event triggers and trigger functions, we don't
> want to duplicate it.

Also added in v8.

Thanks!