Re: Revert: Remove useless self-joins and -DREALLOCATE_BITMAPSETS make server crash, regress test fail.

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>

To: Richard Guo <guofenglinux@gmail.com>, David Rowley <dgrowleyml@gmail.com>

Cc: jian he <jian.universality@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2024-05-07T12:00:25Z

Lists: pgsql-hackers

On 2024-05-07 Tu 06:05, Richard Guo wrote:
>
> On Tue, May 7, 2024 at 1:22 PM David Rowley <dgrowleyml@gmail.com> wrote:
>
>     It would be good to get some build farm coverage of this so we don't
>     have to rely on manual testing.  I wonder if it's a good idea to just
>     define REALLOCATE_BITMAPSETS when #ifdef CLOBBER_FREED_MEMORY... or if
>     we should ask on the buildfarm-members list if someone wouldn't mind
>     defining it?
>
>
> +1 to have build farm coverage of REALLOCATE_BITMAPSETS. This flag
> seems quite useful.
>
>

I have added it to the CPPFLAGS on prion.


cheers


andrew


--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Commits

Make left-join removal safe under -DREALLOCATE_BITMAPSETS.
- c7be3c015bfe 17.0 landed
Revert: Remove useless self-joins
- d1d286d83c0e 17.0 cited
Remove mention of nchar
- 81b2252e609c 17.0 cited