Horton

Re: Convert *GetDatum() and DatumGet*() macros to inline functions

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Aleksander Alekseev <aleksander@timescale.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-09-12T17:59:36Z
Lists: pgsql-hackers 
On 12.09.22 19:03, Julien Rouhaud wrote:
> On Mon, Sep 12, 2022 at 05:59:09PM +0200, Peter Eisentraut wrote:
>>
>> committed, thanks
> 
> FTR lapwing is complaining about this commit:
> https://brekka.postgresql.org/cgi-bin/show_log.pl?nm=lapwing&dt=2022-09-12%2016%3A40%3A18.
> 
> Snapper is also failing with similar problems:
> https://brekka.postgresql.org/cgi-bin/show_log.pl?nm=snapper&dt=2022-09-12%2016%3A42%3A10

Ok, it has problems with 32-bit platforms.  I can reproduce it locally. 
I'll need to take another look at this.  I have reverted the patch for now.

Commits

  1. Convert *GetDatum() and DatumGet*() macros to inline functions

  2. Fix incorrect uses of Datum conversion macros