Horton

Re: Vacuum statistics

Alena Rybakina <a.rybakina@postgrespro.ru>

View thread
From: Alena Rybakina <a.rybakina@postgrespro.ru>
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Alexander Korotkov <aekorotkov@gmail.com>, Jim Nasby <jnasby@upgrade.com>, Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>, Andrei Zubkov <zubkov@moonset.ru>, Masahiko Sawada <sawada.mshk@gmail.com>, Melanie Plageman <melanieplageman@gmail.com>, jian he <jian.universality@gmail.com>, a.lepikhov@postgrespro.ru, Sami Imseih <samimseih@gmail.com>
Date: 2025-03-12T19:36:39Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Move wal_buffers_full from PgStat_PendingWalStats to WalUsage

Hi!

On 10.03.2025 16:33, Kirill Reshke wrote:
> On Thu, 27 Feb 2025 at 23:00, Alena Rybakina<a.rybakina@postgrespro.ru>  wrote:
>> Hi!
>> On 17.02.2025 17:46, Alena Rybakina wrote:
>>> On 04.02.2025 18:22, Alena Rybakina wrote:
>>>> Hi! Thank you for your review!
>>>>
>>>> On 02.02.2025 23:43, Alexander Korotkov wrote:
>>>>> On Mon, Jan 13, 2025 at 3:26 PM Alena Rybakina
>>>>> <a.rybakina@postgrespro.ru>  wrote:
>>>>>> I noticed that the cfbot is bad, the reason seems to be related to
>>>>>> the lack of a parameter in
>>>>>> src/backend/utils/misc/postgresql.conf.sample. I added it, it
>>>>>> should help.
>>>>> The patch doesn't apply cleanly.  Please rebase.
>>>> I rebased them.
>>> The patch needed a rebase again. There is nothing new since version
>>> 18, only a rebase.
>> The patch needed a new rebase.
>>
>> Sorry, but due to feeling unwell I picked up a patch from another thread
>> and squashed the patch for vacuum statistics for indexes and heaps in
>> the previous version. Now I fixed everything together with the rebase.
>>
>> --
>> Regards,
>> Alena Rybakina
>> Postgres Professional
> Hi!
> CI fails on this one[0]
>
> Is it a flap or a real problem caused by v20?
>
> ```
>
>   SELECT relpages AS irp
> diff -U3 /tmp/cirrus-ci-build/src/test/regress/expected/vacuum_tables_and_db_statistics.out
> /tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/data/results/vacuum_tables_and_db_statistics.out
> --- /tmp/cirrus-ci-build/src/test/regress/expected/vacuum_tables_and_db_statistics.out
> 2025-03-10 09:36:10.274799176 +0000
> +++ /tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/data/results/vacuum_tables_and_db_statistics.out
> 2025-03-10 09:49:35.796596462 +0000
> @@ -65,7 +65,7 @@
>   WHERE vt.relname = 'vestat' AND vt.relid = c.oid;
>    relname | vm_new_frozen_pages | tuples_deleted | relpages |
> pages_scanned | pages_removed
>   ---------+---------------------+----------------+----------+---------------+---------------
> - vestat  |                   0 |              0 |      455 |
>     0 |             0
> + vestat  |                   0 |              0 |      417 |
>     0 |             0
>   (1 row)
>
>   SELECT relpages AS rp
> === EOF ===
>
>
> ```
>
> [0]https://api.cirrus-ci.com/v1/artifact/task/5336493629112320/testrun/build-32/testrun/recovery/027_stream_regress/log/regress_log_027_stream_regress
Thank you for your help, I'll fix it soon.

-- 
Regards,
Alena Rybakina
Postgres Professional