Re: ANALYZE ONLY

On 2024-09-09 16:56, Michael Harris wrote:

Thanks for updating the patch.
Here is a minor comment.

> @@ -944,20 +948,32 @@ expand_vacuum_rel(VacuumRelation *vrel, 
> MemoryContext vac_context,
>            MemoryContextSwitchTo(oldcontext);
>        }
..
> +        * Unless the user has specified ONLY, make relation list 
> entries for
> +        * its partitions and/or descendant tables.

Regarding the addition of partition descendant tables, should we also 
update the below comment on expand_vacuum_rel? Currently it refers only 
partitions:

|  * Given a VacuumRelation, fill in the table OID if it wasn't 
specified,
|  * and optionally add VacuumRelations for partitions of the table.

Other than this and the following, it looks good to me.

On Mon, Sep 9, 2024 at 10:27 AM David Rowley <dgrowleyml@gmail.com> 
wrote:
> Aside from those, that just leaves me with the behavioural change. I
> noted Tom was ok with the change in behaviour for ANALYZE (mentioned
> in [1]). Tom, wondering if you feel the same for VACUUM too?  If we're
> doing this, I think we'd need to be quite clear about it on the
> release notes.


-- 
Regards,

--
Atsushi Torikoshi
NTT DATA Group Corporation