Re: List of hostaddrs not supported

Heikki Linnakangas <hlinnaka@iki.fi>

From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, "Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>, Mithun Cy <mithun.cy@enterprisedb.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-07-10T09:30:47Z
Lists: pgsql-hackers
On 06/09/2017 04:26 PM, Robert Haas wrote:
> On Fri, Jun 9, 2017 at 6:36 AM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> Right. I think it's a usability fail as it is; it certainly fooled me. We
>> could make the error messages and documentation more clear. But even better
>> to allow multiple host addresses, so that it works as you'd expect.
>
> Sure, I don't have a problem with that.  I guess part of the point of
> beta releases is to correct things that don't turn out to be as smart
> as we thought they were, and this seems to be an example of that.

I just remembered that this was still pending. I made the documentation 
changes, and committed this patch now.

We're uncomfortably close to wrapping the next beta, later today, but I 
think it's better to get this into the hands of people testing this, 
rather than wait for the next beta. I think the risk of breaking 
something that used to work is small.

- Heikki



Commits

  1. Fix check for empty hostname.

  2. Allow multiple hostaddrs to go with multiple hostnames.

  3. Silence warning about uninitialized 'ret' variable on some compilers.

  4. Give a better error message on invalid hostaddr option.