Re: New developer papercut - Makefile references INSTALL
Peter Eisentraut <peter.eisentraut@enterprisedb.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Daniel Gustafsson <daniel@yesql.se>, Magnus Hagander <magnus@hagander.net>
Cc: Tim McNamara <tim@mcnamara.nz>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-01-18T16:05:36Z
Lists: pgsql-hackers
On 18.01.22 16:51, Daniel Gustafsson wrote: >> On 17 Jan 2022, at 13:26, Daniel Gustafsson <daniel@yesql.se> wrote: >> >>> On 17 Jan 2022, at 11:25, Magnus Hagander <magnus@hagander.net> wrote: >> >>> That said, I'm not sure we're actually gaining anything by *not* >>> referring to the website as well. TBH, I bet the majority of users >>> will actually prefer to read them there. So I'd suggest always >>> including the reference to the website as well, per the suggestion >>> from Tim. >> >> Fair point, I'll go ahead and do that in a bit unless anyone objects. > > I plan on applying the attached which address the feedback given. The indentation of the two INSTRUCTIONS= lines uses a different mix of tabs and spaces, so it looks a bit weird depending on how you view it. It's also a bit strange that the single quotes are part of the value of $INSTRUCTIONS rather than part of the fixed text. The URL links to the "devel" version of the installation instructions, which will not remain appropriate after release. I don't know how to fix that without creating an additional maintenance point. Since README.git already contains that link, I would leave off the web site business and just make the change of the dynamically chosen file name.
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Dynamically find correct installation docs in Makefile.
- c330b75d9cce 15.0 landed