Horton

Re: [PATCH] Add pretty-printed XML output option

Jim Jones <jim.jones@uni-muenster.de>

View thread View on postgr.es
From: Jim Jones <jim.jones@uni-muenster.de>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Peter Smith <smithpb2250@gmail.com>
Cc: Nikolay Samokhvalov <samokhvalov@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Andrey Borodin <amborodin86@gmail.com>
Date: 2023-02-23T08:20:00Z
Lists: pgsql-hackers

Attachments

On 23.02.23 08:51, Peter Eisentraut wrote:
> In kwlist.h you have
>
>     PG_KEYWORD("indent", INDENT, UNRESERVED_KEYWORD, AS_LABEL)
>
> but you can actually make it BARE_LABEL, which is preferable.
>
> More importantly, you need to add the new keyword to the 
> bare_label_keyword production in gram.y.  I thought we had some 
> tooling in the build system to catch this kind of omission, but it's 
> apparently not working right now.
Entry in kwlist.h changed to BARE_LABEL.
>
> Elsewhere, let's rename the xmlformat() C function to xmlserialize() 
> (or maybe something like xmlserialize_indent()), so the association is 
> clearer.
>
xmlserialize_indent sounds much better and makes the association indeed 
clearer. Changed in v19.

v19 attached.

Thanks for the review!

Best, Jim

Commits

  1. Fix memory leak in XMLSERIALIZE(... INDENT).

  2. doc: Move documentation of md5_password_warnings to a better place

  3. Support [NO] INDENT option in XMLSERIALIZE().

  4. Add an expected-file to match behavior of latest libxml2.