Re: speeding up planning with partitions

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Amit Langote <amitlangote09@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: "Imai, Yoshikazu" <imai.yoshikazu@jp.fujitsu.com>, David Rowley <david.rowley@2ndquadrant.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2019-01-10T08:41:21Z
Lists: pgsql-hackers

Attachments

On 2019/01/10 0:16, Amit Langote wrote:
> On Wed, Jan 9, 2019 at 11:41 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>>> From 3b86331dd5a2368adc39c9fef92f3dd09d817a08 Mon Sep 17 00:00:00 2001
>>> From: amit <amitlangote09@gmail.com>
>>> Date: Wed, 7 Nov 2018 16:51:31 +0900
>>> Subject: [PATCH v11 4/6] Move inheritance expansion code into its own file
>>
>> I wonder if it would make sense to commit 0004 ahead of the rest?  To
>> avoid carrying this huge one over and over ...
> 
> Maybe a good idea.  I will rearrange the patches that  way tomorrow.

Here's v12, which is more or less same as v11 but with the order of
patches switched so that the code movement patch is first.  Note that the
attached v12-0001 contains no functional changes (but there's tiny note in
the commit message mentioning the addition of a tiny function which is
just old code).

In the v13 that I will try to post tomorrow, I will have hopefully
addressed David's and Imai-san's review comments.  Thank you both!

Regards,
Amit

Commits

  1. Clean up handling of constraint_exclusion and enable_partition_pruning.

  2. Add test case exercising formerly-unreached code in inheritance_planner.

  3. Speed up planning when partitions can be pruned at plan time.

  4. Avoid crash in partitionwise join planning under GEQO.

  5. Avoid passing query tlist around separately from root->processed_tlist.

  6. Build "other rels" of appendrel baserels in a separate step.

  7. Get rid of duplicate child RTE for a partitioned table.

  8. Rearrange make_partitionedrel_pruneinfo to avoid work when we can't prune.

  9. Don't copy PartitionBoundInfo in set_relation_partition_info.

  10. Move building of child base quals out into a new function

  11. Reorganize planner code moved in b60c39759908

  12. Move inheritance expansion code into its own file

  13. Fix inherited UPDATE/DELETE with UNION ALL subqueries.

  14. Rearrange planner to save the whole PlannerInfo (subroot) for a subquery.