Horton

Re: killing perl2host

Andrew Dunstan <andrew@dunslane.net>

View thread View on postgr.es
From: Andrew Dunstan <andrew@dunslane.net>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2022-02-19T13:48:14Z
Lists: pgsql-hackers 
On 2/18/22 17:34, Andrew Dunstan wrote:
> On 2/17/22 12:12, Andres Freund wrote:
>> Hi,
>>
>> On 2022-02-17 09:20:56 -0500, Andrew Dunstan wrote:
>>> I don't think we have or have ever had a buildfarm animal targeting
>>> msys. In general I think of msys as a build environment to create native
>>> binaries. But if we want to support targeting msys we should have an
>>> animal doing that.
>> It's pretty much cygwin. Wouldn't hurt to have a dedicated animal though, I
>> agree. We do have a dedicated path for it in configure.ac:
>>
>> case $host_os in
>> ...
>>   cygwin*|msys*) template=cygwin ;;
>
>
> FYI I tested it while in wait mode for something else, and it fell over
> at the first hurdle:
>
>
> running bootstrap script ... 2022-02-18 22:25:45.119 UTC [34860] FATAL: 
> could not create shared memory segment: Function not implemented
> 2022-02-18 22:25:45.119 UTC [34860] DETAIL:  Failed system call was
> shmget(key=1407374884304065, size=56, 03600).
> child process exited with exit code 1
>
>
> I'm not intending to put any more effort into supporting it.


See also
<https://postgr.es/m/6b467edc-4018-521f-ab18-171f098557ca@2ndquadrant.com>
where Peter says:


    MSYS2 doesn't ship with cygserver AFAICT, so you can't run a
    PostgreSQL server, but everything else should work.


which explains this perfectly. If we can't run a server then any sort of
buildfarm/CI support seems moot.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

  1. Remove PostgreSQL::Test::Utils::perl2host completely

  2. Remove most msys special processing in TAP tests

  3. Ensure the right perl is used for TAP tests on msys

  4. Disable perl2host() processing in TAP tests