Horton

Thread

Commits

  1. pg_basebackup: Correct type of WalSegSz

  1. pg_basebackup: Correct type of WalSegSz

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> — 2023-03-30T06:24:36Z

    The pg_basebackup code has WalSegSz as uint32, whereas the rest of the 
code has it as int.  This seems confusing, and using the extra range 
wouldn't actually work.  This was in the original commit (fc49e24fa6), 
but I suppose it was an oversight.

  2. Re: pg_basebackup: Correct type of WalSegSz

    Daniel Gustafsson <daniel@yesql.se> — 2023-03-31T08:31:04Z

    > On 30 Mar 2023, at 08:24, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
> 
> The pg_basebackup code has WalSegSz as uint32, whereas the rest of the code has it as int.  This seems confusing, and using the extra range wouldn't actually work.  This was in the original commit (fc49e24fa6), but I suppose it was an oversight.

LGTM, it indeed seems to be an accidental oversight.

--
Daniel Gustafsson