Re: INSERT ... ON CONFLICT DO SELECT [FOR ...] take 2

Andreas Karlsson <andreas@proxel.se>

From: Andreas Karlsson <andreas@proxel.se>
To: Joel Jacobson <joel@compiler.org>, pgsql-hackers <pgsql-hackers@postgresql.org>, Marko Tiikkaja <marko@joh.to>
Date: 2024-12-17T10:45:52Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Add support for INSERT ... ON CONFLICT DO SELECT.

Attachments

On 12/3/24 11:24 AM, Joel Jacobson wrote:
> I've tested the patch successfully and also looked at the code briefly
> and at first glance think it looks nice and clean.

Thanks for the interest!

Here is an updated version which adds support for RLS. I am not 100% 
sure that my choices for RLS are correct since I decided to, similar to 
ON CONFLICT DO UPDATE, throw an error if the RLS checks fail rather than 
filter the RETURNING tuples using the RLS USING clause. I can see a case 
for either and am not familiar enough with RLS to have a good intuition 
for which.

Andreas