Re: [PATCH] updates to docs about HOT updates for BRIN
Jeff Davis <pgsql@j-davis.com>
From: Jeff Davis <pgsql@j-davis.com>
To: Stephen Frost <sfrost@snowman.net>, Alvaro Herrera
<alvherre@alvh.no-ip.org>
Cc: Elizabeth Christensen <elizabeth.christensen@crunchydata.com>, pgsql-hackers@lists.postgresql.org
Date: 2024-03-04T23:32:19Z
Lists: pgsql-hackers
Attachments
- v5-0001-docs-Update-HOT-update-docs-for-19d8e2308b.patch (text/x-patch) patch v5-0001
On Tue, 2024-02-27 at 09:48 -0500, Stephen Frost wrote: > Attached is an updated patch which drops the 'such as' and adds a > sentence mentioning that BRIN is the only in-core summarizing index. The original patch reads more clearly to me. In v4, summarizing (the exception) feels like it's dominating the description. Also, is it standard practice to backport this kind of doc update? I ordinarily wouldn't be inclined to do so, but v4 seems targeted at 16 as well. Attached my own suggested wording that hopefully addresses Stephen and Alvaro's concerns. I agree that it's tricky to write so I took a more minimalist approach: * I got rid of the "In summary" sentence because (a) it's confusing now that we're talking about summarizing indexes; and (b) it's not summarizing anything, it's just redundant. * I removed the mention partial or expression indexes. It's a bit redundant and doesn't seem especially helpful in this context. If this is agreeable I can commit it. Regards, Jeff Davis
Commits
-
docs: Update HOT update docs for 19d8e2308b
- 7a9328e8e405 17.0 landed
- 8870c54d8a17 16.3 landed