Re: More protocol.h replacements this time into walsender.c

Euler Taveira <euler@eulerto.com>

From: "Euler Taveira" <euler@eulerto.com>

To: "Nathan Bossart" <nathandbossart@gmail.com>

Cc: "Jacob Champion" <jacob.champion@enterprisedb.com>, Álvaro Herrera <alvherre@kurilemu.de>, "Dave Cramer" <davecramer@gmail.com>, "PostgreSQL Hackers" <pgsql-hackers@lists.postgresql.org>

Date: 2025-08-06T17:54:13Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Expand usage of macros for protocol characters.
- 9ea3b6f751ab 19 (unreleased) landed
Rename XLogData protocol message to WALData
- 07684443b1e0 19 (unreleased) landed
Use PqMsg_* macros in walsender.c
- 37c7a7eeb6d1 19 (unreleased) landed

On Wed, Aug 6, 2025, at 12:26 AM, Nathan Bossart wrote:
> Okay, I think I've addressed all the latest feedback in v5.
>

LGTM.

I tried to apply your patch and it says

$ git am -3 v5-0001-Expand-usage-of-protocol-characters.patch
Applying: Expand usage of protocol characters.
Warning: commit message did not conform to UTF-8.
You may want to amend it after fixing the message, or set the config
variable i18n.commitEncoding to the encoding your project uses.

It seems your file is ISO-8859-1 but your commit message claims to be UTF-8.

-- 
Euler Taveira
EDB   https://www.enterprisedb.com/