Horton

Re: Rename sync_error_count to tbl_sync_error_count in subscription statistics

Chao Li <li.evan.chao@gmail.com>

View thread View on postgr.es
From: Chao Li <li.evan.chao@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Peter Smith <smithpb2250@gmail.com>, shveta malik <shveta.malik@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Masahiko Sawada <sawada.mshk@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>
Date: 2025-11-14T04:14:55Z
Lists: pgsql-hackers 

> On Nov 13, 2025, at 17:52, vignesh C <vignesh21@gmail.com> wrote:
> 
> On Thu, 13 Nov 2025 at 09:12, Amit Kapila <amit.kapila16@gmail.com> wrote:
>> 
>> On Thu, Nov 13, 2025 at 4:31 AM Peter Smith <smithpb2250@gmail.com> wrote:
>>> 
>>> CURRENT
>>> seq_sync_error_count
>>> sync_error_count
>>> 
>>> MY SUGGESTION
>>> sync_seq_error_count
>>> sync_table_error_count
>>> 
>> 
>> +1. Along with consistency with other column names, it will also make
>> it easier for users to group and query all 'sync' related counts
>> together.
> 
> This seems better, the attached v2 version patch has the changes for the same.
> 
> Regards,
> Vignesh
> <v2-0001-Rename-sync_error_count-to-sync_table_error_count.patch>

V2 overall looks good, a small comment is that the commit message need to be updated:

```
Subject: [PATCH v2] Rename sync_error_count to sync_table_error_count in
 subscription statistics

This patch renames the sync_error_count column to sync_table_error_count in
the pg_stat_subscription_stats view. The new name makes the purpose explicit
```

We now actually rename two fields.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

Commits

  1. Rename two columns in pg_stat_subscription_stats.