Re: pgindent vs. git whitespace check

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>
To: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, John Naylor <john.naylor@enterprisedb.com>, Andrew Dunstan <andrew@dunslane.net>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2023-03-29T18:26:23Z
Lists: pgsql-hackers
> On 29 Mar 2023, at 19:18, Bruce Momjian <bruce@momjian.us> wrote:
> On Thu, Feb 23, 2023 at 09:36:00AM +0100, Daniel Gustafsson wrote:
>>> On 23 Feb 2023, at 05:48, Tom Lane <tgl@sss.pgh.pa.us> wrote:

>>> Mass conversion of /* to // style would answer that,
>>> but would also create an impossible back-patching problem.
>> 
>> Yeah, that sounds incredibly invasive.
> 
> I am replying late here but ...
> 
> We would have to convert all supported branches, and tell all forks to
> do the same (hopefully at the same time).  The new standard would then
> be for all single-line comments to use // instead of /* ... */.

That still leaves every patch which is in flight on -hackers, and conflicts in
local development trees etc.  It's doable (apart from forks, but that cannot be
our core concern), but I personally can't see the price paid justify the result.

--
Daniel Gustafsson




Commits

  1. Fix comment indentation and whitespace