Horton

Thread

Commits

  1. doc: Extend documentation of PG_TEST_EXTRA

  1. Add resource intensiveness as a reason to not running tests by default

    Nazir Bilal Yavuz <byavuz81@gmail.com> — 2023-09-07T11:09:35Z

    Hi,

With f47ed79cc8, the test suite doesn't run 'wal_consistency_checking'
as default because it is resource intensive; but regress docs doesn't
state resource intensiveness as a reason for not running tests by
default. So, I created a patch for updating the docs.

Any kind of feedback would be appreciated.

Regards,
Nazir Bilal Yavuz
Microsoft

  2. Re: Add resource intensiveness as a reason to not running tests by default

    Daniel Gustafsson <daniel@yesql.se> — 2023-09-07T11:24:16Z

    > On 7 Sep 2023, at 13:09, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:

> With f47ed79cc8, the test suite doesn't run 'wal_consistency_checking'
> as default because it is resource intensive; but regress docs doesn't
> state resource intensiveness as a reason for not running tests by
> default. So, I created a patch for updating the docs.

Agreed, the current wording lacks the mention of skipping tests due to high
resource usage.  Patch looks good from a quick skim, I'll backpatch it down to
15 which is where PG_TEST_EXTRA was first used in this capacity.

--
Daniel Gustafsson

  3. Re: Add resource intensiveness as a reason to not running tests by default

    Daniel Gustafsson <daniel@yesql.se> — 2023-09-08T09:39:30Z

    > On 7 Sep 2023, at 13:24, Daniel Gustafsson <daniel@yesql.se> wrote:
> 
>> On 7 Sep 2023, at 13:09, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
> 
>> With f47ed79cc8, the test suite doesn't run 'wal_consistency_checking'
>> as default because it is resource intensive; but regress docs doesn't
>> state resource intensiveness as a reason for not running tests by
>> default. So, I created a patch for updating the docs.
> 
> Agreed, the current wording lacks the mention of skipping tests due to high
> resource usage.  Patch looks good from a quick skim, I'll backpatch it down to
> 15 which is where PG_TEST_EXTRA was first used in this capacity.

Pushed and backpatched, thanks!

--
Daniel Gustafsson