Thread

Re: Trivial Fix: use palloc_array/repalloc_array for BufFile file arrays

Chao Li <li.evan.chao@gmail.com> — 2025-12-25T03:34:48Z

> On Dec 25, 2025, at 11:12, Chao Li <li.evan.chao@gmail.com> wrote:
> 
> Hi Hackers,
> 
> I noticed this error while working on [1].
> 
> In BufFile, the fields is claimed as an array:
> ```
> struct BufFile
> {
>     File *files; /* palloc'd array with numFiles entries */
> ```
> 
> However, it’s allocated by palloc_object():
> ```
> file->files = palloc_object(File);
> ```
> 
> And reallocated by repalloc():
> ```
>     file->files = (File *) repalloc(file->files,
>         (file->numFiles + 1) * sizeof(File));
> ```
> 
> This trivial patch just changes to use palloc_array/repalloc_array, which makes the intent clearer.
> 
> Best regards,
> --
> Chao Li (Evan)
> HighGo Software Co., Ltd.
> https://www.highgo.com/
> 
> 
> 
> 
> <v1-0001-Use-palloc_array-repalloc_array-for-BufFile-file-.patch>


Sorry for missing the reference of [1]:

[1] https://postgr.es/m/aUStrqoOCDRFAq1M@paquier.xyz

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/