Horton
Menu

Re: [PATCH] Add tests for Bitmapset

Greg Burd <greg@burd.me>

View thread
From: Greg Burd <greg@burd.me>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>, Nathan Bossart <nathandbossart@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Michael Paquier <michael@paquier.xyz>
Date: 2025-09-18T18:50:45Z
Lists: pgsql-hackers

Attachments

Hello hackers, :)

Thanks for all the feedback and time spent reviewing this patch.  I
switched out the encode/decode functions to use the nodeToString() and
stringToNode() functions and change all the SQL testing function
signatures to TEXT from BYTEA.  This exercises more code and that's good
for testing purposes.  I took out the code that checks the hash values,
I can't think of a reason that should cause a future failure should that
change and output different values.  I re-integrated the earlier random
testing function along with the newer code.  I'm not sure this buys us
much if anything.

coverage:      HEAD      v7
lines......:   87.1    90.5   +3.4%
functions..:  100.0   100.0   +0.0%
branches...:   63.5    75.9  +12.4%

best.

-greg

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Minor fixes for test_bitmapset.c

  2. test_bitmapset: Improve random function

  3. Add mem_exceeded_count column to pg_stat_replication_slots.

  4. Tidy-up unneeded NULL parameter checks from SQL function

  5. Remove check for NULL in STRICT function

  6. Fixes for comments in test_bitmapset

  7. Minor fixups of test_bitmapset.c

  8. test_bitmapset: Simplify code of the module

  9. test_bitmapset: Expand more the test coverage

  10. Fix compiler warnings in test_bitmapset

  11. Add a test module for Bitmapset