Horton

Re: PG vs macOS Mojave

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Jakob Egger <jakob@eggerapps.at>, pgsql-hackers@lists.postgresql.org
Date: 2018-11-02T15:01:26Z
Lists: pgsql-hackers 
> On 2 Nov 2018, at 15:42, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> I wrote:
>> Here's a lightly-tested patch for that approach.
> 
> Anybody have an opinion about which approach to use?  We need to choose
> one, and PDQ too, if we want full buildfarm coverage on it before Monday's
> wrap.

Sorry for being slow to respond, I was hoping to find time for testing but it’s
a scarce resource right now.

> The main argument in favor of #1 (restore use of -isysroot) is fear that
> Apple's going to force us into that sometime soon anyhow, so we might as
> well just bite the bullet instead of inserting weird workarounds to avoid
> it.  But perhaps that isn't going to happen.

#1 is the option that appeals to me the most, mostly because it removes all
possible ambiguity of when/if it’s required compared to #2.

+     Most Postgres developers just turn off SIP, though.

Minor nitpick, shouldn’t this be <productname>Postgres</productname>?

cheers ./daniel

Commits

  1. Yet further rethinking of build changes for macOS Mojave.

  2. Still further rethinking of build changes for macOS Mojave.

  3. Back off using -isysroot on Darwin.

  4. Make some fixes to allow building Postgres on macOS 10.14 ("Mojave").