Re: Cold welcoming message when installing anything because of LLVM bitcode stuff

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: pgsql-hackers@lists.postgresql.org,Tom Lane <tgl@sss.pgh.pa.us>,Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Date: 2018-04-28T18:14:59Z
Lists: pgsql-hackers

On April 28, 2018 11:05:15 AM PDT, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>Michael Paquier <michael@paquier.xyz> writes:
>> JIT is introducing the installation of LLVM bitcode modules, and any
>> installation done results in the following comment in output, which
>> repeats basically for all the extensions installed:
>> # Then install files
>> #
>> # The many INSTALL_DATA invocations aren't particularly fast, it'd be
>> # good if we could coalesce them, but I didn't find a good way.
>
>> Andres, could it be possible to move at least that block of comments
>in
>> a place where this is not user-visible?

Yes, that seems sensible. I don't think they hurt much given the existing verbosity, but they don't add anything.


>  Close inspection of the
>"make install" output revealed a few other issues, which I hope
>I fixed rather than making things worse.

Broke the llvm enabled part of the bf. Will have a look once I'm home (1.5h), unless you get to it first.

Andres
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.


Commits

  1. Un-break contrib install with llvm.

  2. Minor cleanups for install_llvm_module/uninstall_llvm_module Make macros.