Re: Fix LOCK_TIMEOUT handling in slotsync worker

> On Dec 9, 2025, at 13:34, Amit Kapila <amit.kapila16@gmail.com> wrote:
> 
> On Mon, Dec 8, 2025 at 1:06 PM Chao Li <li.evan.chao@gmail.com> wrote:
>> 
>> I have nit comment:
>> 
>> ```
>> -       if (ShutdownRequestPending)
>> +       if (SlotSyncCtx->stopSignaled)
>>        {
>>                ereport(LOG,
>> -                               errmsg("replication slot synchronization worker is shutting down on receiving SIGINT"));
>> +                               errmsg("replication slot synchronization worker is shutting down because promotion is triggered"));
>> ```
>> 
>> In the error message, “because promotion is triggered" sound a little redundant, can be just:
>> 
>> "replication slot synchronization worker is shutting down due to promotion"
>> 
> 
> We have a number of existing similar messages like:  "logical
> replication parallel apply worker for subscription \"%s\" will stop
> because of a parameter change". So, how about: "replication slot
> synchronization worker will stop because promotion is triggered"?
> 
> -- 
> With Regards,
> Amit Kapila.

Yeah, I just searched and see similar messages:

```
logical replication parallel apply worker for subscription \"%s\" will stop because the subscription owner's superuser privileges have been revoked

logical replication worker for subscription \"%s\" will restart because the subscription owner's superuser privileges have been revoked
```

I think the new phrase is better. Maybe “is triggered” could be “has been triggered”?

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/