Re: Remove obsolate comments from 047_checkpoint_physical_slot
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
Alexander Korotkov <aekorotkov@gmail.com>
Date: 2025-09-25T07:32:40Z
Lists: pgsql-hackers
> On 25 Sep 2025, at 09:23, Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com> wrote:
>
> Dear hackers,
>
>> While reviewing others, I found $SUBJECT.
>
> I found another cleanup point related with this. In CreateCheckPoint():
>
> ```
> #ifdef USE_INJECTION_POINTS
> INJECTION_POINT("checkpoint-before-old-wal-removal");
> #endif
> ```
>
> Here USE_INJECTION_POINTS check is not needed. If the feature is disabled,
> the macro function would be ((void) name). IIUC, we are using the macro if if-branch
> exists.
+1, that's not needed (and not used elsewhere in the code either).
--
Daniel Gustafsson
Commits
-
Remove preprocessor guards from injection points
- efc26d17a7d4 18.1 landed
- 53a2246ddf9b 17.7 landed
- 0b3ce7878af7 19 (unreleased) landed
-
Fix comments in recovery tests
- d8f07dbb81a1 19 (unreleased) landed