Re: [PATCH] Improve geometric types

Tomas Vondra <tomas.vondra@2ndquadrant.com>

From: Tomas Vondra <tomas.vondra@2ndquadrant.com>

To: Jeff Janes <jeff.janes@gmail.com>

Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, Emre Hasegeli <emre@hasegeli.com>, Thomas Munro <thomas.munro@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2018-07-29T20:35:17Z

Lists: pgsql-hackers

Attachments

geo-compiler-warning.patch (text/x-patch) patch

On 07/29/2018 05:11 PM, Tomas Vondra wrote:
> 
> 
> On 07/29/2018 04:31 PM, Jeff Janes wrote:
>>
>>
>> On Sat, Jul 28, 2018 at 9:54 PM, Tomas Vondra
>> <tomas.vondra@2ndquadrant.com <mailto:tomas.vondra@2ndquadrant.com>> wrote:
>>
>>
>>
>>     I've committed the first two parts, after a review and testing.
>>
>>
>> I'm getting a compiler warning now:
>>
>> geo_ops.c: In function 'line_closept_point':
>> geo_ops.c:2528:7: warning: variable 'retval' set but not used
>> [-Wunused-but-set-variable]
>>   bool  retval;
>>  
> 
> Yeah, the variable is apparently only used in an assert. Will fix.
> 

This should fix it I guess, and it's how we deal with unused return
values elsewhere. I've considered using USE_ASSERT_CHECKING here, but it
seems rather ugly with that. I'll wait for Emre's opinion ...

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

Improve test coverage of geometric types
- a3d2844852dc 12.0 landed
Fix problems in handling the line data type
- 2e2a392de391 12.0 landed
Use the built-in float datatypes to implement geometric types
- c4c340088546 12.0 landed
Remove remaining GEODEBUG references from geo_ops.c
- a082aed0723c 12.0 landed
Provide separate header file for built-in float types
- 6bf0bc842bd7 12.0 landed
Refactor geometric functions and operators
- a7dc63d904a6 12.0 landed
Fix crash in close_ps() for NaN input coordinates.
- 278148907a97 9.6.0 cited
Fix GiST index build for NaN values in geometric types.
- 1acf75725545 9.6.0 cited
Enable building with Visual Studion 2013.
- cec8394b5ccd 9.4.0 cited
Suppress -0 in the C field of lines computed by line_construct_pts().
- 43fe90f66a0b 9.4.0 cited