Re: Reducing memory consumed by RestrictInfo list translations in partitionwise join planning

Alena Rybakina <lena.ribackina@yandex.ru>

From: Alena Rybakina <lena.ribackina@yandex.ru>

To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Richard Guo <guofenglinux@gmail.com>, David Rowley <dgrowleyml@gmail.com>

Date: 2023-11-24T10:26:53Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add assertion to verify derived clause has constant RHS
- 887160d1beae 18.0 landed
Make derived clause lookup in EquivalenceClass more efficient
- 88f55bc97622 18.0 landed
Doc: improve documentation for jsonpath behavior.
- 7014c9a4bba2 17.0 cited
Work around implementation restriction in adjust_appendrel_attrs.
- 767c598954bb 16.0 cited

On 24.11.2023 13:20, Alena Rybakina wrote:
>
> Hi! Thank you for your work on the subject, I think it's a really 
> useful feature.
>
> I've reviewed your patch and I have a few questions.
>
> First of all, have you thought about creating a gun parameter to 
> display memory scheduling information? I agree that this is an 
> important feature, but I think only for debugging.
>
> Secondly, I noticed that for the child_rinfo_hash key you use a 
> counter (int) and can it lead to collisions? Why didn't you generate a 
> hash from childRestrictInfo for this? For example, something like how 
> it is formed here [0].
>
> [0] 
> https://www.postgresql.org/message-id/43ad8a48-b980-410d-a83c-5beebf82a4ed%40postgrespro.ru 
>
>
Sorry, my first question was not clear, I mean: have you thought about 
creating a guc parameter to display memory planning information?

-- 
Regards,
Alena Rybakina