RE: [BUG] Assert failure in ReorderBufferReturnTXN during logical decoding due to leaked specinsert change

Dear Hayato, Álvaro,

>> Please don't do this. Changing the argument list of an exported
>> function is an ABI break. That's an OK change to do in branch master
>> (to keep the interface clean), but for released branches it is not
>> welcome, because it causes problems for users that have extensions that
>> call the function and were compiled with its older definition.
>
> To confirm, ReorderBufferResetTXN() seems a static function and proposed patch
> does not modify *.h files. So they do not break the ABI and OK to remove, right?

```
File: reorderbuffer.c
2156: /*
2157:  * Helper function for ReorderBufferProcessTXN to handle the concurrent
2158:  * abort of the streaming transaction.  This resets the TXN such that it
2159:  * can be used to stream the remaining data of transaction being processed.
2160:  * This can happen when the subtransaction is aborted and we still want to
2161:  * continue processing the main or other subtransactions data.
2162:  */
2163: static void
2164: ReorderBufferResetTXN(ReorderBuffer *rb, ReorderBufferTXN *txn,
```

Confirmed, `ReorderBufferResetTXN()` is a static function used only by ReorderBufferProcessTXN().
It is not exposed outside reorderbuffer.c, and the patch does not affect any public exported function.


Regards,
Vishal Prasanna
Zoho Corporation