Horton

Re: doc: add missing "id" attributes to extension packaging page

Brar Piening <brar@gmx.de>

View thread View on postgr.es
From: Brar Piening <brar@gmx.de>
To: "Karl O. Pinc" <kop@karlpinc.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: vignesh C <vignesh21@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Ian Lawrence Barwick <barwick@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-01-10T05:28:10Z
Lists: pgsql-hackers 
On 09.01.2023 at 23:28, Karl O. Pinc wrote:
> On Mon, 09 Jan 2023 15:18:18 -0500
> Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> It's probably going to be necessary to have follow-on patches,
>> because I'm sure there is stuff in the pipeline that adds more
>> ID-less tags.  Or do we have a way to create warnings about that?
> I am unclear on how to make warnings with xslt.  You can make
> a listing of problems, but who would read it if the build
> completed successfully?  You can make errors and abort.

You can emit warnings to the command line or you can abort with an
error. I've opted for warnings + comments in the output in the styling
patch.

The biggest issue about errors and warnings is the fact that xslt does
not process files in a line-based way which makes it pretty much
impossible to give hints where the problem causing the warning is
located. Since everything is bound together via XML entities, you can't
even tell the source file.

I've worked around this by also emitting an HTML comment to the output
so that I can find a somewhat unique string next to it and the grep the
documentation sources for this string. It's a bit ugly but the best I
could come up with.

I'll repost a rebased version of the styling patch in a minute.

Regards,

Brar

Commits

  1. doc: Make HTML ids discoverable

  2. Add missing XML ID attribute

  3. postgres_fdw: Add support for parallel abort.

  4. Add missing XML ID attributes

  5. Add XML ID attributes to create_subscription.sgml.

  6. Stop recommending auto-download of DTD files, and indeed disable it.

  7. Doc: add XML ID attributes to <sectN> and <varlistentry> tags.

  8. Allow left join removals and unique joins on partitioned tables

  9. Improve GIN cost estimation