Re: Injection points: some tools to wait and wake
x4mmm@yandex-team.ru
From: "Andrey M. Borodin" <x4mmm@yandex-team.ru>
To: Michael Paquier <michael@paquier.xyz>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
Postgres hackers <pgsql-hackers@lists.postgresql.org>,
Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: 2024-02-26T09:10:49Z
Lists: pgsql-hackers
> On 26 Feb 2024, at 08:57, Michael Paquier <michael@paquier.xyz> wrote: > > <v4-0001-injection_points-Add-routines-to-wait-and-wake-pr.patch> Would it be possible to have a helper function to check this: +ok( $node_standby->poll_query_until( + 'postgres', + qq[SELECT count(*) FROM pg_stat_activity + WHERE backend_type = 'checkpointer' AND wait_event = 'CreateRestartPoint' ;], + '1'), + 'checkpointer is waiting in restart point' +) or die "Timed out while waiting for checkpointer to run restart point”; So that we could do something like ok(node_standby->await_injection_point(“CreateRestartPoint”,”checkpointer")); IMO, this could make many tests cleaner. Or, perhaps, it’s a functionality for a future development? Thanks! Best regards, Andrey Borodin.
Commits
-
Add PostgreSQL::Test::Cluster::wait_for_event()
- eca2c1ea85eb 17.0 landed
-
Add regression test for restart points during promotion
- 6782709df81f 17.0 landed
-
injection_points: Add wait and wakeup of processes
- 37b369dc67bc 17.0 landed