Horton

Re: [PATCH] Add features to pg_stat_statements

btkatsuragiyu <btkatsuragiyu@oss.nttdata.com>

View thread View on postgr.es
From: Katsuragi Yuta <btkatsuragiyu@oss.nttdata.com>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-09-23T06:48:15Z
Lists: pgsql-hackers 
On 2020-09-18 18:49, Julien Rouhaud wrote:
> Did you consider also adding the cumulated number of
> evicted entries?  This could be useful to know how to configure
> pg_stat_statements.max.

Thank you for your comments!
I overlooked the cumulated number of evicted entries.
This statistic looks important. But, I am not sure
if I should add this statistic to a view.
This is because I am not sure how to utilize the cumulated
number of evicted entries for configuring pg_stat_statements.max.

Not only providing a view but also logging evictions
along with the number of evicted entries might be a choice.
This idea is from legrand legrand [1].

[1] 
https://www.postgresql.org/message-id/1600500942767-0.post%40n3.nabble.com

Regards,
Katsuragi Yuta

Commits

  1. pg_stat_statements: Track number of times pgss entries were deallocated.