Horton

Re: [HACKERS] UPDATE of partition key

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Khandekar <amitdkhan.pg@gmail.com>, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, pgsql-hackers <pgsql-hackers@postgresql.org>, Thomas Munro <thomas.munro@enterprisedb.com>
Date: 2018-01-21T06:43:18Z
Lists: pgsql-hackers 
Robert Haas <robertmhaas@gmail.com> writes:
> Committed with a bunch of mostly-cosmetic revisions.

Buildfarm member skink has been unhappy since this patch went in.
Running the regression tests under valgrind easily reproduces the
failure.  Now, I might be wrong about which of the patches committed
on Friday caused the unhappiness, but the valgrind backtrace sure
looks like it's to do with partition routing:

==00:00:05:49.683 17549== Invalid read of size 4
==00:00:05:49.683 17549==    at 0x62A8BA: ExecCleanupTupleRouting (execPartition.c:483)
==00:00:05:49.683 17549==    by 0x6483AA: ExecEndModifyTable (nodeModifyTable.c:2682)
==00:00:05:49.683 17549==    by 0x627139: standard_ExecutorEnd (execMain.c:1604)
==00:00:05:49.683 17549==    by 0x7780AF: ProcessQuery (pquery.c:206)
==00:00:05:49.683 17549==    by 0x7782E4: PortalRunMulti (pquery.c:1286)
==00:00:05:49.683 17549==    by 0x778AAF: PortalRun (pquery.c:799)
==00:00:05:49.683 17549==    by 0x774E4C: exec_simple_query (postgres.c:1120)
==00:00:05:49.683 17549==    by 0x776C17: PostgresMain (postgres.c:4143)
==00:00:05:49.683 17549==    by 0x6FA419: PostmasterMain (postmaster.c:4412)
==00:00:05:49.683 17549==    by 0x66E51F: main (main.c:228)
==00:00:05:49.683 17549==  Address 0xe25e298 is 2,088 bytes inside a block of size 32,768 alloc'd
==00:00:05:49.683 17549==    at 0x4A06A2E: malloc (vg_replace_malloc.c:270)
==00:00:05:49.683 17549==    by 0x89EB15: AllocSetAlloc (aset.c:945)
==00:00:05:49.683 17549==    by 0x8A7577: palloc (mcxt.c:848)
==00:00:05:49.683 17549==    by 0x671969: new_list (list.c:68)
==00:00:05:49.683 17549==    by 0x672859: lappend_oid (list.c:169)
==00:00:05:49.683 17549==    by 0x55330E: find_inheritance_children (pg_inherits.c:144)
==00:00:05:49.683 17549==    by 0x553447: find_all_inheritors (pg_inherits.c:203)
==00:00:05:49.683 17549==    by 0x62AC76: ExecSetupPartitionTupleRouting (execPartition.c:68)
==00:00:05:49.683 17549==    by 0x64949D: ExecInitModifyTable (nodeModifyTable.c:2232)
==00:00:05:49.683 17549==    by 0x62BBE8: ExecInitNode (execProcnode.c:174)
==00:00:05:49.683 17549==    by 0x627B53: standard_ExecutorStart (execMain.c:1043)
==00:00:05:49.683 17549==    by 0x778046: ProcessQuery (pquery.c:156)

(This is my local result, but skink's log looks about the same.)

			regards, tom lane

Commits

  1. Avoid referencing off the end of subplan_partition_offsets.

  2. Allow UPDATE to move rows between partitions.

  3. Remove useless lookup of root partitioned rel in ExecInitModifyTable().

  4. Factor error generation out of ExecPartitionCheck.

  5. Minor preparatory refactoring for UPDATE row movement.

  6. Simplify and encapsulate tuple routing support code.

  7. Avoid coercing a whole-row variable that is already coerced.

  8. Use ResultRelInfo ** rather than ResultRelInfo * for tuple routing.

  9. Make RelationGetPartitionDispatchInfo expand depth-first.

  10. Expand partitioned tables in PartDesc order.

  11. Use a real RT index when setting up partition tuple routing.

  12. Fix transition tables for partition/inheritance.

  13. Fix confusion about number of subplans in partitioned INSERT setup.

  14. Prevent BEFORE triggers from violating partitioning constraints.

  15. Fire per-statement triggers on partitioned tables.

  16. Fix reporting of violations in ExecConstraints, again.

  17. Don't scan partitioned tables.

  18. Allow FDWs to push down quals without breaking EvalPlanQual rechecks.