Re: Dubious coding in nbtinsert.c

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-04-08T20:57:59Z
Lists: pgsql-hackers
Peter Geoghegan <pg@bowt.ie> writes:
> You had a near-identical complaint about a compiler warning that led
> to my commit d64f1cdf2f4 -- that one involved _bt_check_unique()'s
> curitup, while this one is about curitemid. While I have no problem
> silencing this compiler warning now, I don't see any reason to not
> just do the same thing again. Which is to initialize the pointer to
> NULL.

Works for me; if there is any bug in the logic, we'll get a core dump
and can investigate.

			regards, tom lane



Commits

  1. Silence another _bt_check_unique compiler warning.

  2. Silence _bt_check_unique compiler warning.