Horton

Re: pgsql: Use data directory inode number, not port, to select SysV resour

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: pgsql-committers@lists.postgresql.org
Date: 2019-09-06T15:35:13Z
Lists: pgsql-hackers 
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 9/5/19 1:32 PM, Tom Lane wrote:
>> Use data directory inode number, not port, to select SysV resource keys.

> This has caused the 017_shm.pl tests to be skipped on jacana and
> bowerbird, and to fail completely on my msys2 test system where the Perl
> has the relevant IPC:: modules, unlike the buildfarm animals.

I intended 017_shm.pl to be skipped on Windows builds; it's not apparent
to me that that script tests anything useful when we're not using SysV
shared memory.

I don't quite understand what the msys2 platform might be doing with
these IPC modules.  Do they actually do anything, or just fail at
runtime?  If the latter, maybe we can add something to the eval{}
block to check for present-but-doesnt-work?

			regards, tom lane

Commits

  1. Always skip recovery SysV shared memory tests on Windows

  2. Use data directory inode number, not port, to select SysV resource keys.