Re: pgsql: autovacuum: handle analyze for partitioned tables
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2021-04-08T18:47:01Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes: > On 2021-Apr-08, Tom Lane wrote: >> Yeah. I hit this on another machine that isn't using EXEC_BACKEND, >> and I concur it looks more like a race condition. I think the problem >> is that autovacuum is calling find_all_inheritors() on a relation it >> has no lock on, contrary to that function's API spec. > Hmm. Autovacuum tries hard to avoid grabbing locks on relations until > really needed (at vacuum/analyze time), which is why all these tests > only use data that can be found in the pg_class rows and pgstat entries. Yeah, I was worried about that. > So I tend to think that my initial instinct was the better direction: we > should not be doing any find_all_inheritors() here at all, but instead > rely on pg_class.reltuples to be set for the partitioned table. +1 regards, tom lane
Commits
-
Describe (auto-)analyze behavior for partitioned tables
- 1b5617eb844c 14.0 landed
-
Add comment about extract_autovac_opts not holding lock
- 7c298c6573a0 14.0 landed
-
Set pg_class.reltuples for partitioned tables
- 0e69f705cc1a 14.0 landed
-
autovacuum: handle analyze for partitioned tables
- 0827e8af70f4 14.0 cited