Re: CREATE UNLOGGED TABLE seq faults when debug_discard_caches=1
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Cc: Spyridon Dimitrios Agathos <spyridon.dimitrios.agathos@gmail.com>
Date: 2022-11-17T17:51:28Z
Lists: pgsql-hackers
Attachments
- backpatch-f10f0ae42-v14.patch (text/x-diff) patch v14
I wrote: > I wonder whether we ought to back-patch f10f0ae42. We could > leave the RelationOpenSmgr macro in existence to avoid unnecessary > breakage of extension code, but stop using it within our own code. Concretely, about like this for v14 (didn't look at the older branches yet). I'm not sure whether to recommend that outside extensions switch to using RelationGetSmgr in pre-v15 branches. If they do, they run a risk of compile failure should they be built against old back-branch headers. Once compiled, though, they'd work against any minor release (since RelationGetSmgr is static inline, not something in the core backend). So maybe that'd be good enough, and keeping their code in sync with what they need for v15 would be worth something. regards, tom lane
Commits
-
Replace RelationOpenSmgr() with RelationGetSmgr().
- e21856fd652a 12.14 landed
- d4acf2eb94f3 11.19 landed
- 9a299cf7c21f 13.10 landed
- 32d5a4974c81 14.7 landed
- f10f0ae420ee 15.0 cited