Re: pg_upgrade test chatter

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Bossart, Nathan" <bossartn@amazon.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2021-10-19T18:00:40Z
Lists: pgsql-hackers
"Bossart, Nathan" <bossartn@amazon.com> writes:
> I run 'make check-world' a lot, and I typically use parallelism and
> redirect stdout to /dev/null as suggested in the docs [0].  This seems
> to eliminate all of the test chatter except for this one message:

>         NOTICE:  database "regression" does not exist, skipping

Yeah, that's bugged me too ever since we got to the point where that
was the only output ...

> We could also just create the
> database it is trying to drop to silence the NOTICE.

... but that seems like a mighty expensive way to fix it.
createdb is pretty slow on older/slower buildfarm animals.

Maybe we could run the stderr output through "grep -v", or the like?

			regards, tom lane



Commits

  1. Improve pg_regress.c's infrastructure for issuing psql commands.