Horton

Re: Converting contrib SQL functions to new style

Ronan Dunklau <ronan.dunklau@aiven.io>

View thread View on postgr.es
From: Ronan Dunklau <ronan.dunklau@aiven.io>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Date: 2024-11-05T09:14:02Z
Lists: pgsql-hackers

Attachments

Le lundi 4 novembre 2024, 17:10:01 heure normale d’Europe centrale Tom Lane a 
écrit :
> The cfbot says many of these fail regression tests --- lots of
> 
>  CREATE EXTENSION citext SCHEMA s;
> +ERROR:  extension "citext" has no installation script nor update path for
> version "1.8"
> 
> and such.  I didn't poke into why, but maybe you missed "git add'ing"
> some changes?
> 

Sorry you're right I missed one for xml2. But most importantly I forgot to 
update the meson build files for every one of them, using only the Makefile...

Please find attached a new version which should make this right. 

Regards,

--
Ronan Dunklau

Commits

  1. Use @extschema:name@ notation in contrib transform modules.

  2. pg_freespacemap: Fix declaration of pg_freespace(regclass)

  3. contrib/pageinspect: Use SQL-standard function bodies.

  4. contrib/xml2: Use SQL-standard function bodies.

  5. contrib/citext: Use SQL-standard function bodies.

  6. contrib/earthdistance: Use SQL-standard function bodies.

  7. contrib/lo: Use SQL-standard function bodies

  8. xml2: Add tests for functions xpath_nodeset() and xpath_list()

  9. contrib/lo: Add test for function lo_oid()

  10. pg_freespacemap: Use SQL-standard function bodies

  11. Add @extschema:name@ and no_relocate options to extensions.

  12. Make contrib modules' installation scripts more secure.