Re: [HACKERS] Source code format vote

Bruce Momjian <pgman@candle.pha.pa.us>

From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 1999-12-30T17:09:24Z
Lists: pgsql-hackers
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Current votes are:
> > (8)     8-space tabs:   Tom Lane, Peter E., Massimo, Jan, Hiroshi, Peter M.,
> >                         Michael, Tatsuo
> > (5)     4-space tabs:   Bruce, Andreas, Vince, Vadim, D'Arcy
> 
> >         open bracket on if () line:
> > (7)     yes:    Massimo, Peter, Vince, Tom Lane, Peter M., Marc, Tatsuo  
> > (6)     no:     Bruce, Vadim, D'Arcy, Jan, Hiroshi, Michael M.
> 
> > Looks like radical change will come to our source code format for 7.0.
> 
> It looks to me like there is consensus to change the tab spacing (which
> is NOT the same as the logical indent step, for those newcomers who
> don't seem to be aware of the difference).
> 
> However, I don't see a consensus to change the bracket layout.
> 7-to-6 is not enough of a margin to justify a wholesale code change.
> Especially considering that my original vote was NO, which Bruce chose
> to interpret as YES ;-).  Change it back to NO, and the vote is the
> other way.
> 
> I think what we have is a consensus to change the physical tab spacing
> but leave the look of the code alone...

OK, change tab to 8 spaces, keep indent at 4 spaces, and keep open
bracked on a separate line.  Got it.



-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026