Horton

Re: [BUGS] Postgresql on Ultraparc/Linux , Bug report and patch!

Bruce Momjian <pgman@candle.pha.pa.us>

View thread
From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Silvio Macedo <smacedo@ic.ac.uk>, bugs@postgreSQL.org
Date: 1999-11-25T18:45:34Z
Lists: pgsql-bugs 
> Silvio Macedo <smacedo@ic.ac.uk> writes:
> > In src/backend/utils/adt/name.c you do:
> >     return (bool) strncmp(arg1->data, arg2->data, NAMEDATALEN) == 0;
> > In this way you are casting strncmp to bool, and not the comparison.
> 
> Oops.  Good catch!
> 
> Wonder if there are similar mistakes elsewhere?  If so, how could we
> find them?

Patch applied.  I just went through utils/adt/*.c looking for bool, and
the rest look OK.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026