Thread

1. Re: [BUGS] 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc

   Tom Lane <tgl@sss.pgh.pa.us> — 1999-10-08T15:16:57Z

   "Pedro J. Lobo" <pjlobo@euitt.upm.es> writes:
   > Someone has changed the "#if defined(__alpha)" tests that existed in
   > include/storage/s_lock.h in 6.5.1 to "#if defined(__alpha__)". The problem
   > is that DEC (Compaq?) C only defines __alpha, (gcc defines both __alpha
   > and __alpha__) so it doesn't work anymore.
   
   I thought that was bogus when it was done.  Should be
   	#if defined(__alpha) || defined(__alpha__)
   to cover both compilers.
   
   > In fact, there are two places where the test is used, one inside a "#if
   > defined(__GNUC__)" and the other one inside the corresponding "#else". It
   > seems that the easiest sollution is to change the check inside the "#else"
   > back to "#if defined(__alpha)".
   
   ... which would break whichever compiler is being used by the person who
   submitted the patch.  I don't think it was changed on a whim.
   
   			regards, tom lane
   
   

2. Re: [BUGS] 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc

   Bruce Momjian <maillist@candle.pha.pa.us> — 1999-10-08T17:07:40Z

   > "Pedro J. Lobo" <pjlobo@euitt.upm.es> writes:
   > > Someone has changed the "#if defined(__alpha)" tests that existed in
   > > include/storage/s_lock.h in 6.5.1 to "#if defined(__alpha__)". The problem
   > > is that DEC (Compaq?) C only defines __alpha, (gcc defines both __alpha
   > > and __alpha__) so it doesn't work anymore.
   > 
   > I thought that was bogus when it was done.  Should be
   > 	#if defined(__alpha) || defined(__alpha__)
   > to cover both compilers.
   > 
   > > In fact, there are two places where the test is used, one inside a "#if
   > > defined(__GNUC__)" and the other one inside the corresponding "#else". It
   > > seems that the easiest sollution is to change the check inside the "#else"
   > > back to "#if defined(__alpha)".
   > 
   > ... which would break whichever compiler is being used by the person who
   > submitted the patch.  I don't think it was changed on a whim.
   
   I recommend putting something in the alpha template to define __alpha,
   so we don't have to double-compare everywhere.  I will make the change
   now.
   
   
   -- 
     Bruce Momjian                        |  http://www.op.net/~candle
     maillist@candle.pha.pa.us            |  (610) 853-3000
     +  If your life is a hard drive,     |  830 Blythe Avenue
     +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
   
   

3. Re: [BUGS] 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc

   Bruce Momjian <maillist@candle.pha.pa.us> — 1999-10-08T17:14:10Z

   > "Pedro J. Lobo" <pjlobo@euitt.upm.es> writes:
   > > Someone has changed the "#if defined(__alpha)" tests that existed in
   > > include/storage/s_lock.h in 6.5.1 to "#if defined(__alpha__)". The problem
   > > is that DEC (Compaq?) C only defines __alpha, (gcc defines both __alpha
   > > and __alpha__) so it doesn't work anymore.
   > 
   > I thought that was bogus when it was done.  Should be
   > 	#if defined(__alpha) || defined(__alpha__)
   > to cover both compilers.
   > 
   > > In fact, there are two places where the test is used, one inside a "#if
   > > defined(__GNUC__)" and the other one inside the corresponding "#else". It
   > > seems that the easiest sollution is to change the check inside the "#else"
   > > back to "#if defined(__alpha)".
   > 
   > ... which would break whichever compiler is being used by the person who
   > submitted the patch.  I don't think it was changed on a whim.
   
   New code in Makefile.alpha is:
   
   	/* some platforms define __alpha, but not __alpha__ */
   	#if defined(__alpha) && !defined(__alpha__)
   	#define __alpha__
   	#endif
   
   -- 
     Bruce Momjian                        |  http://www.op.net/~candle
     maillist@candle.pha.pa.us            |  (610) 853-3000
     +  If your life is a hard drive,     |  830 Blythe Avenue
     +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
   
   

4. Re: [PORTS] Re: [BUGS] 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc

   Uncle George <gatgul@voicenet.com> — 1999-10-10T11:38:13Z

   egcs, also defines both __alpha & __alpha__
   ( if u havent't test there already ) I believe this covers all avail compiled
   on the Digital Alpha  box
   gat
   Tom Lane wrote:
   
   > "Pedro J. Lobo" <pjlobo@euitt.upm.es> writes:
   > > Someone has changed the "#if defined(__alpha)" tests that existed in
   > > include/storage/s_lock.h in 6.5.1 to "#if defined(__alpha__)". The problem
   > > is that DEC (¿Compaq?) C only defines __alpha, (gcc defines both __alpha
   > > and __alpha__) so it doesn't work anymore.
   >
   > I thought that was bogus when it was done.  Should be
   >         #if defined(__alpha) || defined(__alpha__)
   > to cover both compilers.
   >
   > > In fact, there are two places where the test is used, one inside a "#if
   > > defined(__GNUC__)" and the other one inside the corresponding "#else". It
   > > seems that the easiest sollution is to change the check inside the "#else"
   > > back to "#if defined(__alpha)".
   >
   > ... which would break whichever compiler is being used by the person who
   > submitted the patch.  I don't think it was changed on a whim.
   >
   >                         regards, tom lane
   >
   > ************