Re: [HACKERS] drop before create in pg_dump

Bruce Momjian <maillist@candle.pha.pa.us>

From: Bruce Momjian <maillist@candle.pha.pa.us>
To: tgl@sss.pgh.pa.us (Tom Lane)
Cc: brook@trillium.NMSU.Edu, hackers@postgreSQL.org, patches@postgreSQL.org
Date: 1999-01-16T03:50:51Z
Lists: pgsql-hackers
> Brook Milligan <brook@trillium.NMSU.Edu> writes:
> > pg_dump won't drop stuff before trying to create it; this makes
> > dropping a single table (say) and recreating it difficult to automate
> > since it is subject to error if all the stuff doesn't get dropped
> > properly.  The following patch causes pg_dump to emit DROP ...
> > statements prior to emitting CREATE ... statements.
> 
> I think that ought to be driven by a switch to pg_dump ...
> much of the time, I would *want* pg_dump's script to fail
> if there's already an existing item of the given name.
> 
> I see your concern, I just don't think it's the only scenario.

I agree.  I don't like it removing stuff before creating it.  pg_dump
already does a lot.  But I do agree it is difficult to automate
destroy/create.


-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026