Re: [HACKERS] Re: [SQL] plpgsql error

Bruce Momjian <maillist@candle.pha.pa.us>

From: Bruce Momjian <maillist@candle.pha.pa.us>
To: Jan Wieck <jwieck@debis.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, brook@trillium.NMSU.Edu, hackers@postgreSQL.org
Date: 1999-05-12T12:50:17Z
Lists: pgsql-hackers
> >
> > Brook Milligan <brook@trillium.NMSU.Edu> writes:
> > > Isn't the correct solution to have the Makefile contain a rule that
> > > creates the file from a template (e.g., with sed -e
> > > 's/@xxx@/${xxx}/g')?  That way make resolves the variable references
> > > and you needn't worry about it.
> >
> > (after further thought...)  Oh, right, I see what you're saying: don't
> > generate mklang.sql in configure at all, but let pl/plpgsql/src/Makefile
> > be responsible for it.  Yeah, that'd be a cleaner solution.  However,
> > what I just committed works ;-).  If you feel like improving it, be
> > my guest; I have other items on the to-do list...
> 
>     I've  just  committed  a  little  change  to  initdb and it's
>     Makefile. The initdb Makefile now expands  __DLSUFFIX__  into
>     it  and  initdb uses $PGLIB/plpgsql__DLSUFFIX__ to test if it
>     is there  and  then  runs  the  appropriate  queries  against
>     template1. Same for PL/Tcl.
> 
>     If  anyone  agrees we can get rid of these mklang.sql scripts
>     totally.

Sure.


-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026