Re: [HACKERS] perl interface bug?

Bruce Momjian <maillist@candle.pha.pa.us>

From: Bruce Momjian <maillist@candle.pha.pa.us>
To: brook@trillium.NMSU.Edu (Brook Milligan)
Cc: tgl@sss.pgh.pa.us, E.Mergl@bawue.de, hackers@postgreSQL.org
Date: 1998-10-15T19:26:30Z
Lists: pgsql-hackers
>    Edmund is thinking of a different situation.  The perl5 interface is
>    also a "Perl module", which means that it is supposed to build and
>    install under very rigid rules --- this is supposed to work:
> 		   perl Makefile.PL
> 		   make
> 		   make test
> 		   make install
> 
> Ok, I see now.  So, we need the following:
> 
> - a Makefile.PL that works out of the box for the above sequence,
>   given that POSTGRES_HOME is set properly.
> 
> - a Makefile.PL that works with the Postgres installation and gets the
>   right shared library, so if we run `make test' later (or use the
>   interface in any way) it works immediately upon Postgres
>   installation.
> 
> A solution:
> 
> - a default Makefile.PL that works
> 
> - a Makefile.PL replaced from Makefile.PL.in that still works with the
>   above, but satisfies the second criterion.
> 
> The patches below do this and I think satisfy all considerations
> (you'll let me know if they don't, right? :)
> 
> - Makefile.PL has an explanation and if POSTGRES_HOME is not set will
>   print a useful message.
> 
> - Makefile.PL.in replaces that message with the right thing for
>   finding the installed shared library based on configure.
> 
> - Makefile:  same as before; do the clean before installing to pick up
>   the right shared library.  Note that no clean is done for any other
>   targets.
> 
> - configure.in:  output Makefile.PL along with the rest.  Note also,
>   that in the current version $WHOAMI is never set so the perl test
>   always fails.  Perhaps this should be fixed by setting the variable
>   correctly, but in any case the comments no longer agree with this
>   stuff anyway.
> 
> Cheers,
> Brook

This patch does not apply properly.  Please resubmit.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026