Re: [HACKERS] Some cleanups/enhancements

Applied.  Looked good, and qsort.c removed as you suggested.


> There's a patch attached to fix gcc 2.8.x warnings, except for the
> yyerror ones from bison. It also includes a few 'enhancements' to the C
> programming style (which are, of course, personal).
> 
> The other patch removes the compilation of backend/lib/qsort.c, as
> qsort() is a standard function in stdlib.h and can be used any where
> else (and it is). It was only used in
> backend/optimizer/geqo/geqo_pool.c, backend/optimizer/path/predmig.c,
> and backend/storage/page/bufpage.c
> 
> > > Some or all of these changes might not be appropriate for v6.3, since we
> > > are in beta testing and since they do not affect the current functionality.
> > > For those cases, how about submitting patches based on the final v6.3
> > > release?
> 
> There's more to come. Please review these patches. I ran the regression
> tests and they only failed where this was expected (random, geo, etc).
> 
> Cheers,
> 
> Jeroen


-- 
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)