Thread

  1. Re: [HACKERS] SunOS patches

    Tatsuo Ishii <t-ishii@sra.co.jp> — 1998-03-02T03:21:26Z

    >> ----------------------------------------------------------------------
    >> *** backend/libpq/pqcomm.c.orig	Fri Feb 27 14:07:52 1998
    >> --- backend/libpq/pqcomm.c	Fri Feb 27 14:08:50 1998
    >> ***************
    >> *** 564,571 ****
    >>    * Shutdown routine for backend connection
    >>    * If a Unix socket is used for communication, explicitly close it.
    >>    */
    >> ! static void
    >> ! do_unlink()
    >>   {
    >>   	if (sock_path[0])
    >>   		unlink(sock_path);
    >> --- 564,571 ----
    >>    * Shutdown routine for backend connection
    >>    * If a Unix socket is used for communication, explicitly close it.
    >>    */
    >> ! void
    >> ! StreamDoUnlink()
    >
    >
    >	What breaks by renaming this function?? :(
    
    Nothing. do_unlink() is called only from line 648 and the line was
    deleted by my patches.
    Just removing "static" from the declaration of do_unlink might be ok.
    However function name "do_unlink" would be too general IMHO.
    --
    Tatsuo Ishii
    t-ishii@sra.co.jp