Thread

  1. Declaration glitch in arrayfuncs.c

    Tom Ivar Helbekkmo <tih@hamartun.priv.no> — 1998-02-14T15:30:02Z

    Probably fixed already, since it's uncompilable, but anyway:
    
    The file 'backend/utils/adt/arrayfuncs.c' won't compile with the
    February 14th snapshot, because of an inconsistency between the
    declaration and implementation of ReadArrayStr().  As far as I can
    tell, the predeclaration is wrong.  I assume this is what was meant:
    
    *** backend/utils/adt/arrayfuncs.c.ORIG	Sat Feb 14 09:00:31 1998
    --- backend/utils/adt/arrayfuncs.c	Sat Feb 14 15:52:29 1998
    ***************
    *** 44,52 ****
      /*-=-=--=-=-=-=-=-=-=-=--=-=-=-=-=-=-=-=--=-=-=-=-=-=-=-=--=-=-=-=-=-=-=-*/
      static int	_ArrayCount(char *str, int dim[], int typdelim);
      static char *_ReadArrayStr(char *arrayStr, int nitems, int ndim, int dim[],
    ! 			  FmgrInfo *inputproc, Oid typelem, char typdelim,
    ! 			  int typlen, bool typbyval, char typalign,
    ! 			  int *nbytes, int16 typmod);
      
      #ifdef LOARRAY
      static char *
    --- 44,52 ----
      /*-=-=--=-=-=-=-=-=-=-=--=-=-=-=-=-=-=-=--=-=-=-=-=-=-=-=--=-=-=-=-=-=-=-*/
      static int	_ArrayCount(char *str, int dim[], int typdelim);
      static char *_ReadArrayStr(char *arrayStr, int nitems, int ndim, int dim[],
    ! 			  FmgrInfo *inputproc, Oid typelem, int16 typmod,
    ! 			  char typdelim, int typlen, bool typbyval,
    ! 			  char typalign, int *nbytes);
      
      #ifdef LOARRAY
      static char *
    
    
    -tih
    -- 
    Popularity is the hallmark of mediocrity.  --Niles Crane, "Frasier"
    
    
    
  2. Re: [HACKERS] Declaration glitch in arrayfuncs.c

    Bruce Momjian <maillist@candle.pha.pa.us> — 1998-02-15T01:12:22Z

    Gee, I noticed the compile was broken, but did not realize is was me. 
    Thanks.
    
    
    > 
    > Probably fixed already, since it's uncompilable, but anyway:
    > 
    > The file 'backend/utils/adt/arrayfuncs.c' won't compile with the
    > February 14th snapshot, because of an inconsistency between the
    > declaration and implementation of ReadArrayStr().  As far as I can
    > tell, the predeclaration is wrong.  I assume this is what was meant:
    > 
    > *** backend/utils/adt/arrayfuncs.c.ORIG	Sat Feb 14 09:00:31 1998
    > --- backend/utils/adt/arrayfuncs.c	Sat Feb 14 15:52:29 1998
    > ***************
    > *** 44,52 ****
    >   /*-=-=--=-=-=-=-=-=-=-=--=-=-=-=-=-=-=-=--=-=-=-=-=-=-=-=--=-=-=-=-=-=-=-*/
    >   static int	_ArrayCount(char *str, int dim[], int typdelim);
    >   static char *_ReadArrayStr(char *arrayStr, int nitems, int ndim, int dim[],
    > ! 			  FmgrInfo *inputproc, Oid typelem, char typdelim,
    > ! 			  int typlen, bool typbyval, char typalign,
    > ! 			  int *nbytes, int16 typmod);
    >   
    >   #ifdef LOARRAY
    >   static char *
    > --- 44,52 ----
    >   /*-=-=--=-=-=-=-=-=-=-=--=-=-=-=-=-=-=-=--=-=-=-=-=-=-=-=--=-=-=-=-=-=-=-*/
    >   static int	_ArrayCount(char *str, int dim[], int typdelim);
    >   static char *_ReadArrayStr(char *arrayStr, int nitems, int ndim, int dim[],
    > ! 			  FmgrInfo *inputproc, Oid typelem, int16 typmod,
    > ! 			  char typdelim, int typlen, bool typbyval,
    > ! 			  char typalign, int *nbytes);
    >   
    >   #ifdef LOARRAY
    >   static char *
    > 
    > 
    > -tih
    > -- 
    > Popularity is the hallmark of mediocrity.  --Niles Crane, "Frasier"
    > 
    > 
    > 
    
    
    -- 
    Bruce Momjian
    maillist@candle.pha.pa.us