Thread

Re: [HACKERS] postmaster crash and .s.pgsql file

Goran Thyni <goran@bildbasen.se> — 1998-01-27T08:37:04Z

   On Mon, 26 Jan 1998, Bruce Momjian wrote:

   : 
   : When the postmaster crashes, it leaves the /tmp/.s.pgsql file in /tmp.
   : Is there a way to auto-remove it after a postmaster crash?
   : 
   : -- 
   : Bruce Momjian
   : maillist@candle.pha.pa.us
   : 

   I found that when using "-S" with postmaster, the file doesn't get
   created at all. 

I have submitted a patch for this before,
I think a got applied, maybe it has been 
(accidently) reverted since.
(patch below)

The same goes for Bruce's problem with
socket name being 1 char short.

   I will look at removing the file on startup when I'm in there.

Don't, it gets removed at shutdown except when crashing.
Removing at startup opens a whole new can of worms.
(You must no postmaster is not already running.)

     regards,
-- 
---------------------------------------------
Gran Thyni, sysadm, JMS Bildbasen, Kiruna


------------------ snip -----------------------------------

diff -c src/backend/postmaster/postmaster.c.orig src/backend/postmaster/postmaster.c
*** /databaser/pg-sup/pgsql/src/backend/postmaster/postmaster.c.orig	Mon Jan 26 08:46:08 1998
--- /databaser/pg-sup/pgsql/src/backend/postmaster/postmaster.c	Tue Jan 27 09:35:21 1998
***************
*** 482,488 ****
  	{
  		fprintf(stderr, "%s: ", progname);
  		perror("cannot disassociate from controlling TTY");
! 		exit(1);
  	}
  #endif
  	i = open(NULL_DEV, O_RDWR);
--- 482,488 ----
  	{
  		fprintf(stderr, "%s: ", progname);
  		perror("cannot disassociate from controlling TTY");
! 		_exit(1);
  	}
  #endif
  	i = open(NULL_DEV, O_RDWR);