Re: [HACKERS] S_LOCK() change produces error...

Bruce Momjian <maillist@candle.pha.pa.us>

From: Bruce Momjian <maillist@candle.pha.pa.us>
To: scrappy@hub.org (The Hermit Hacker)
Cc: pgsql-hackers@postgreSQL.org
Date: 1998-01-18T02:59:43Z
Lists: pgsql-hackers
> 
> 
> I installed some patches today for the univel port, and one of the changes
> did the following to include/storage/s_lock.h:
> 
> 302c318
> <                               __asm__("xchgb %0,%1": "=q"(_res), "=m"(*lock):"0"(0x1)); \
> ---
> >                               __asm__("lock xchgb %0,%1": "=q"(_res), "=m"(*lock):"0"(0x1)); \
> 

I guess this is a multiple cpu modifier for asm, and most people don't
run multiple cpus.  I guess our gcc's call it an error, rather than
ignore it.  I think we need an OS-specific ifdef there.  We can't have
Univel changing the normal i386 stuff that works so well now.

-- 
Bruce Momjian
maillist@candle.pha.pa.us