Thread

1. Re: [HACKERS] Current sources?

   Tatsuo Ishii <t-ishii@sra.co.jp> — 1998-05-25T09:14:58Z

   >> PPC/Linux has been broken too.
   >
   >Please let me know what the problem was, even if it was just the 'global tas'
   >thing. I am trying to make sure this works on all platforms. Thanks.
   
   Here are patches for s_lock.c (against May23 snapshot).
   ----------------------------------------------------------
   *** s_lock.c.orig	Mon May 25 18:08:20 1998
   --- s_lock.c	Mon May 25 18:08:57 1998
   ***************
   *** 151,161 ****
     
     #if defined(PPC)
     
   ! static int
   ! tas_dummy()
     {
     	__asm__("				\n\
   - tas:						\n\
     			lwarx	5,0,3	\n\
     			cmpwi	5,0		\n\
     			bne		fail	\n\
   --- 151,160 ----
     
     #if defined(PPC)
     
   ! int
   ! tas(slock_t *lock)
     {
     	__asm__("				\n\
     			lwarx	5,0,3	\n\
     			cmpwi	5,0		\n\
     			bne		fail	\n\
   ----------------------------------------------------------
   >> I have tested the s_lock_test and seems it is working. However I have
   >> lots of failure with various SQL's including 'drop database', 'delete
   >> from'.
   >> Have you succeeded in running regression tests? If so, what kind of
   >> platforms are you using?
   >
   >I made this patch against 6.3.2 and ran regression successfully. This on a
   >glibc Linux x86 system. I just rebuilt against the latest CVS (from anoncvs)
   >and see 27 tests that fail, many with dropconns. I looked a little into the
   >'drop database failure' and it does not look related to spinlocks as far as
   >I looked.
   
   I see. BTW, I have tested on FreeBSD box and found exactly same thing
   has occured.
   --
   Tatsuo Ishii
   t-ishii@sra.co.jp
   
   

2. Re: [HACKERS] Current sources?

   Bruce Momjian <maillist@candle.pha.pa.us> — 1998-06-16T07:53:39Z

   > 
   > >> PPC/Linux has been broken too.
   > >
   > >Please let me know what the problem was, even if it was just the 'global tas'
   > >thing. I am trying to make sure this works on all platforms. Thanks.
   > 
   > Here are patches for s_lock.c (against May23 snapshot).
   > ----------------------------------------------------------
   > *** s_lock.c.orig	Mon May 25 18:08:20 1998
   > --- s_lock.c	Mon May 25 18:08:57 1998
   > ***************
   > *** 151,161 ****
   >   
   >   #if defined(PPC)
   >   
   > ! static int
   > ! tas_dummy()
   >   {
   >   	__asm__("				\n\
   > - tas:						\n\
   >   			lwarx	5,0,3	\n\
   >   			cmpwi	5,0		\n\
   >   			bne		fail	\n\
   > --- 151,160 ----
   >   
   >   #if defined(PPC)
   >   
   > ! int
   > ! tas(slock_t *lock)
   >   {
   >   	__asm__("				\n\
   >   			lwarx	5,0,3	\n\
   >   			cmpwi	5,0		\n\
   >   			bne		fail	\n\
   
   This patch appears to have been applied already.
   
   -- 
   Bruce Momjian                          |  830 Blythe Avenue
   maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
     +  If your life is a hard drive,     |  (610) 353-9879(w)
     +  Christ can be your backup.        |  (610) 853-3000(h)
   
   

3. Re: [HACKERS] Current sources?

   David Gould <dg@illustra.com> — 1998-06-16T08:20:36Z

   > > >> PPC/Linux has been broken too.
   > > >
   > > >Please let me know what the problem was, even if it was just the 'global tas'
   > > >thing. I am trying to make sure this works on all platforms. Thanks.
   > > 
   > > Here are patches for s_lock.c (against May23 snapshot).
   > > ----------------------------------------------------------
   > > *** s_lock.c.orig	Mon May 25 18:08:20 1998
   > > --- s_lock.c	Mon May 25 18:08:57 1998
   > > ***************
   > > *** 151,161 ****
   > >   
   > >   #if defined(PPC)
   > >   
   > > ! static int
   > > ! tas_dummy()
   > >   {
   > >   	__asm__("				\n\
   > > - tas:						\n\
   > >   			lwarx	5,0,3	\n\
   > >   			cmpwi	5,0		\n\
   > >   			bne		fail	\n\
   > > --- 151,160 ----
   > >   
   > >   #if defined(PPC)
   > >   
   > > ! int
   > > ! tas(slock_t *lock)
   > >   {
   > >   	__asm__("				\n\
   > >   			lwarx	5,0,3	\n\
   > >   			cmpwi	5,0		\n\
   > >   			bne		fail	\n\
   > 
   > This patch appears to have been applied already.
   > 
   > -- 
   
   Yes. I picked up all the S_LOCK related patches and messages from the
   mailinglist and folded them into the big S_LOCK patch that just got commited.
   So, unless I have messed up, or someone comes up with something new, no
   other S_LOCK patches should be applied.
   
   Thanks
   
   -dg
   
   David Gould           dg@illustra.com            510.628.3783 or 510.305.9468
   Informix Software                      300 Lakeside Drive   Oakland, CA 94612
    - A child of five could understand this!  Fetch me a child of five.