Re: [Patch]Add Graph* node support to expression_tree_mutator

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Robert Haas <robertmhaas@gmail.com>
Cc: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-05-04T15:39:23Z
Lists: pgsql-hackers
On 30.04.26 08:44, Ashutosh Bapat wrote:
> On Thu, Apr 30, 2026 at 2:17 AM Robert Haas <robertmhaas@gmail.com> wrote:
>>
> 
> Thanks for reviewing the patch.
> 
>> Thanks for working on this. I ran into it independently today, and
>> then discovered this thread. In expression_tree_mutator_impl,
>> T_GraphLabelRef can be added to the "Primitive node types with no
>> expression subnodes" section just as was done in
>> expression_tree_walker_impl.
> 
> Right. Fixed in the attached patch. Both GraphPropertyLabel and
> GraphLabelRef need to be placed in that section since both are
> primitive nodes.

Committed.  (I reformatted the test query a little bit as you had 
suggested upstream.  Also, the ordering of the switch cases was slightly 
different between the walker and the mutator, which I fixed.)