Re: Removing savepointLevel from TransactionState

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Gurjeet Singh <singh.gurjeet@gmail.com>

Cc: PGSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2011-09-29T05:11:52Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Replace nested-BEGIN syntax for subtransactions with spec-compliant
- cc813fc2b8d9 8.0.0 cited

Gurjeet Singh <singh.gurjeet@gmail.com> writes:
> I noticed that the savepointLevel member of TransactionStateData struct is
> initialized to 0 from TopTransactionStateData, and never incremented or
> decremented afterwards.

> Since this is a file-local struct I think we can simply get rid of all
> usages of this without any risk.

ISTM you have detected a bug, not just dead code that should be removed.
Surely those tests that throw error on savepointLevel change were
meant to do something important?

			regards, tom lane